Skip to content

Commit

Permalink
Split ramenctl deploy and config
Browse files Browse the repository at this point in the history
ramenctl config is fails from time to time when:
- Waiting for policies to propagate to managed clusters
- Failing to access ramen webhook when adding a drcluster

The first issue may be a bug in ocm that we need to reproduce and
investigate locally.

The second issue may be a bug in the way we wait for ramen, but I think
there is no good way to wait until a webhook is available, it can fail
even if the container is running. This issue will be resolved soon by
removing the ramen webhooks. This is a temporary error that should be
resolved by retrying.

Until we resolve both issues, lets retry the config step on errors.

Signed-off-by: Nir Soffer <[email protected]>
  • Loading branch information
nirs authored and raghavendra-talur committed Mar 19, 2024
1 parent f94601a commit a980eeb
Showing 1 changed file with 9 additions and 4 deletions.
13 changes: 9 additions & 4 deletions .github/workflows/e2e.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -51,13 +51,18 @@ jobs:
drenv start --max-workers ${{ env.MAX_WORKERS }} --name-prefix ${{ env.NAME_PREFIX }} envs/regional-dr.yaml
- name: Deploy ramen
run: |
ramenctl deploy --name-prefix ${{ env.NAME_PREFIX }} test/envs/regional-dr.yaml
ramenctl config --name-prefix ${{ env.NAME_PREFIX }} test/envs/regional-dr.yaml
run: ramenctl deploy --name-prefix ${{ env.NAME_PREFIX }} test/envs/regional-dr.yaml

- name: Configure ramen
uses: nick-fields/retry@v3
with:
timeout_seconds: 60
max_attempts: 3
command: ramenctl config --name-prefix ${{ env.NAME_PREFIX }} test/envs/regional-dr.yaml

- name: Run e2e tests
run: |
cp ~/.config/drenv/${{ env.NAME_PREFIX }}rdr/config.yaml ../e2e/config.yaml
cp ~/.config/drenv/${{ env.NAME_PREFIX }}rdr/config.yaml e2e/config.yaml
make e2e-rdr
- name: Delete clusters
Expand Down

0 comments on commit a980eeb

Please sign in to comment.