Don't delete PVC when reconciling VRs as secondary

The PVC is owned by OCM and will be removed by OCM. The same reason used
in RamenDR#1007, but we don't know about any issue caused by this attempt.

Fixes: RamenDR#1022
Updates: 165fec2
Signed-off-by: Nir Soffer <[email protected]>
(cherry picked from commit fbc629a)

controllers/vrg_volrep.go

@@ -140,12 +140,7 @@ func (v *VRGInstance) reconcileVRAsSecondary(pvc *corev1.PersistentVolumeClaim,
 		skip    bool = true
 	)
 
-	if pvc.GetAnnotations() != nil && pvc.GetAnnotations()[RestoreAnnotation] == RestoredByRamen {
-		// We created the PVC, delete it
-		if deleted := v.deletePVCIfNotInUse(pvc, log); !deleted {
-			return requeue, false, skip
-		}
-	} else if !v.isPVCReadyForSecondary(pvc, log) {
+	if !v.isPVCReadyForSecondary(pvc, log) {
 		return requeue, false, skip
 	}
 
@@ -177,14 +172,6 @@ func (v *VRGInstance) isPVCReadyForSecondary(pvc *corev1.PersistentVolumeClaim,
 	return !v.isPVCInUse(pvc, log, "Secondary transition")
 }
 
-func (v *VRGInstance) deletePVCIfNotInUse(pvc *corev1.PersistentVolumeClaim, log logr.Logger) bool {
-	if v.isPVCInUse(pvc, log, "PVC deletion") {
-		return false
-	}
-
-	return rmnutil.DeletePVC(v.ctx, v.reconciler.Client, pvc.Name, pvc.Namespace, log) == nil
-}
-
 func (v *VRGInstance) isPVCInUse(pvc *corev1.PersistentVolumeClaim, log logr.Logger, operation string) bool {
 	const inUse bool = true
 	// Check if any pod definitions exist referencing the PVC