Bug 2232242: Refactoring metrics creation and initialisation #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@raghavendra-talur: Bugzilla bug 2232242 is in a bug group that is not in the allowed groups for this repo.
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: raghavendra-talur The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: rakeshgm <[email protected]> (cherry picked from commit 05ea1b9)
Signed-off-by: rakeshgm <[email protected]> (cherry picked from commit c58cd34)
postpone metrics creation till updateResourceCondition is called. Do not set metrics if metro-dr. skip drpc lastGroup status for relocate Signed-off-by: rakeshgm <[email protected]> (cherry picked from commit c443b6e)
raghavendra-talur
force-pushed
the
rtalur-backport-1062
branch
from
72ea772
to
cade68a
Compare
raghavendra-talur
merged commit 6a21d69
into
red-hat-storage:release-4.14
12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Metrics were previously created regardless of metro-dr or regional-dr. This has now changed, metrics are not created for metro-dr. The metrics instance creation is also moved from DRPC instance creation to updating DRPC condition, this is done so as not to initialize and set the default value as 0.
The values now refer to DRPC status and not VRG. we update DPRC LastGroup statuses based on the availability of VRG lastGroupSyncTime and the Relocate action. In case we do not get VRG, metrics will have the previous or the last known value from DRPC.
Removed 0 value filtering from alerts. So alerts are fired when metrics have zero value which is set based on DRPC lastGroupSynctime.
BZ: 2232242