Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2252880: Exclude VolSync secret Policy from hub backup & regenerate ManifestWork on hub restore #160

Merged
merged 3 commits into from
Dec 8, 2023

Conversation

BenamarMk
Copy link
Collaborator

No description provided.

Benamar Mekhissi added 3 commits December 7, 2023 12:07
Upon hub recovery, it is essential to regenerate the VRG ManifestWorks. For CephFS workloads,
two VRG ManifestWorks are necessary—one for the primary cluster and another for the secondary
cluster. However, Ramen failed to regenerate the secondary VRG ManifestWork due to a bug. The
bug originated from a condition that determined whether to regenerate the ManifestWork based
solely on the number of VRGs found on the managed cluster. Consequently, if the count met the
required number, the regeneration was bypassed without considering the actual count of
ManifestWorks. This oversight led to ACM evicting the VRG from the secondary cluster after
the default one-hour eviction time.

Signed-off-by: Benamar Mekhissi <[email protected]>
(cherry picked from commit d9b5ffa)
Signed-off-by: Benamar Mekhissi <[email protected]>
(cherry picked from commit 9dd1c15)
Signed-off-by: Benamar Mekhissi <[email protected]>
(cherry picked from commit ca7af2d)
Copy link

openshift-ci bot commented Dec 7, 2023

@BenamarMk: This pull request references Bugzilla bug 2252933, which is invalid:

  • expected the bug to target the "ODF 4.14.1" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2252933: Exclude VolSync secret Policy from hub backup & regenerate ManifestWork on hub restore

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

openshift-ci bot commented Dec 7, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BenamarMk

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BenamarMk BenamarMk closed this Dec 7, 2023
Copy link

openshift-ci bot commented Dec 7, 2023

@BenamarMk: An error was encountered removing this pull request from the external tracker bugs for bug 2252933 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message. response code 400 not 200

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

Bug 2252933: Exclude VolSync secret Policy from hub backup & regenerate ManifestWork on hub restore

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@BenamarMk BenamarMk changed the title Bug 2252933: Exclude VolSync secret Policy from hub backup & regenerate ManifestWork on hub restore Bug 2252880: Exclude VolSync secret Policy from hub backup & regenerate ManifestWork on hub restore Dec 7, 2023
Copy link

openshift-ci bot commented Dec 7, 2023

@BenamarMk: This pull request references Bugzilla bug 2252880, which is invalid:

  • expected the bug to target the "ODF 4.14.1" release, but it targets "ODF 4.14.2" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2252880: Exclude VolSync secret Policy from hub backup & regenerate ManifestWork on hub restore

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ShyamsundarR ShyamsundarR reopened this Dec 8, 2023
Copy link

openshift-ci bot commented Dec 8, 2023

@BenamarMk: This pull request references Bugzilla bug 2252880, which is invalid:

  • expected the bug to target the "ODF 4.14.1" release, but it targets "ODF 4.14.2" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2252880: Exclude VolSync secret Policy from hub backup & regenerate ManifestWork on hub restore

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ShyamsundarR ShyamsundarR merged commit a1a89f6 into red-hat-storage:release-4.14 Dec 8, 2023
21 of 24 checks passed
Copy link

openshift-ci bot commented Dec 8, 2023

@BenamarMk: All pull requests linked via external trackers have merged:

Bugzilla bug 2252880 has been moved to the MODIFIED state.

In response to this:

Bug 2252880: Exclude VolSync secret Policy from hub backup & regenerate ManifestWork on hub restore

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants