Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syncing latest changes from upstream main for ramen #170

Merged
merged 10 commits into from
Jan 13, 2024
Merged

Conversation

df-build-team
Copy link

PR containing the latest commits from upstream main branch

ELENAGER and others added 10 commits January 12, 2024 09:07
- When filtering update events, consider also the update when the new
  object is marked for deletion.
- When filtering drpcs consider all drpcs referencing a deleted
  drcluster.

With this change, when a drcluster is deleted, the drpc controller
updates the VRG ManifestWork on the remaining cluster. Previously this
happened minutes after a drcluster was deleted.

Notes:

- We don't get a delete event when the drcluster is deleted, but an
  update event. I don't know if this is a bug in controller runtime or
  expected behavior.

Signed-off-by: Nir Soffer <[email protected]>
commands run:
go get github.com/csi-addons/kubernetes-csi-addons@latest
go get github.com/stolostron/[email protected]
go get open-cluster-management.io/[email protected]
go get open-cluster-management.io/[email protected]
go get open-cluster-management.io/[email protected]
go mod tidy

Signed-off-by: Raghavendra Talur <[email protected]>
Signed-off-by: Raghavendra Talur <[email protected]>
Signed-off-by: Raghavendra Talur <[email protected]>

 Please enter the commit message for your changes. Lines starting
@df-build-team df-build-team requested a review from a team January 13, 2024 08:07
Copy link

openshift-ci bot commented Jan 13, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: df-build-team

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ShyamsundarR ShyamsundarR merged commit 8aaed55 into main Jan 13, 2024
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants