-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 2280927: Backport of upstream PR #1573 #374
Bug 2280927: Backport of upstream PR #1573 #374
Conversation
Command run: `go get -u github.com/ramendr/recipe` cherry-pick equivalent of bf4114f Signed-off-by: Raghavendra Talur <[email protected]>
Signed-off-by: Raghavendra Talur <[email protected]> Co-Authored-by: Annaraya Narasagond <[email protected]> (cherry picked from commit 4565dc2)
Changes are: 1. Find the backup and restore workflow by name as CaptureWorkflow and RecoverWorkflow don't exist anymore. 2. Change timeout to int 3. Change command to string type Signed-off-by: Raghavendra Talur <[email protected]> Co-Authored-by: Annaraya Narasagond <[email protected]> (cherry picked from commit 790a54f)
@raghavendra-talur: This pull request references Bugzilla bug 2280927, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: Akarsha-rai. Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@raghavendra-talur: This pull request references Bugzilla bug 2280927, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: Akarsha-rai. Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Command run: `go get -u github.com/ramendr/ramen/api/v1alpha1` Essentially a cherry-pick of 3b85faa Signed-off-by: Raghavendra Talur <[email protected]>
5f7c3c9
to
6766ced
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: BenamarMk, raghavendra-talur The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ddba269
into
red-hat-storage:release-4.17
@raghavendra-talur: All pull requests linked via external trackers have merged: Bugzilla bug 2280927 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Co-Authored-by: @asn1809