Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2280927: Backport of upstream PR #1573 #374

Merged

Conversation

raghavendra-talur
Copy link
Collaborator

@raghavendra-talur raghavendra-talur commented Oct 10, 2024

  • Updated the go.mod file to use the newer version of the Recipe API
  • Added the updated Recipe CRD to the test directory
  • Replaced references to non-existent workflows (CaptureWorkflow and RecoverWorkflow) with the appropriate backup and restore workflow names.
  • Updated the timeout attribute type from a string to an integer
  • Changed the command attribute type from []string to string
  • Fixed tests.

Co-Authored-by: @asn1809

Command run: `go get -u github.com/ramendr/recipe`

cherry-pick equivalent of bf4114f

Signed-off-by: Raghavendra Talur <[email protected]>
Signed-off-by: Raghavendra Talur <[email protected]>
Co-Authored-by: Annaraya Narasagond <[email protected]>
(cherry picked from commit 4565dc2)
Changes are:
1. Find the backup and restore workflow by name as CaptureWorkflow and
   RecoverWorkflow don't exist anymore.
2. Change timeout to int
3. Change command to string type

Signed-off-by: Raghavendra Talur <[email protected]>
Co-Authored-by: Annaraya Narasagond <[email protected]>
(cherry picked from commit 790a54f)
Copy link

openshift-ci bot commented Oct 10, 2024

@raghavendra-talur: This pull request references Bugzilla bug 2280927, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.17.0) matches configured target release for branch (ODF 4.17.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @Akarsha-rai

In response to this:

Bug 2280927: Backport of upstream PR RamenDR#1573

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

openshift-ci bot commented Oct 10, 2024

@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: Akarsha-rai.

Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@raghavendra-talur: This pull request references Bugzilla bug 2280927, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.17.0) matches configured target release for branch (ODF 4.17.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @Akarsha-rai

In response to this:

Bug 2280927: Backport of upstream PR RamenDR#1573

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

openshift-ci bot commented Oct 10, 2024

@raghavendra-talur: This pull request references Bugzilla bug 2280927, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.17.0) matches configured target release for branch (ODF 4.17.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @Akarsha-rai

In response to this:

Bug 2280927: Backport of upstream PR RamenDR#1573

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

openshift-ci bot commented Oct 10, 2024

@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: Akarsha-rai.

Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@raghavendra-talur: This pull request references Bugzilla bug 2280927, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.17.0) matches configured target release for branch (ODF 4.17.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @Akarsha-rai

In response to this:

Bug 2280927: Backport of upstream PR RamenDR#1573

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Command run: `go get -u github.com/ramendr/ramen/api/v1alpha1`

Essentially a cherry-pick of 3b85faa

Signed-off-by: Raghavendra Talur <[email protected]>
Copy link
Collaborator

@BenamarMk BenamarMk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

openshift-ci bot commented Oct 10, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BenamarMk, raghavendra-talur

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BenamarMk BenamarMk merged commit ddba269 into red-hat-storage:release-4.17 Oct 10, 2024
15 of 16 checks passed
Copy link

openshift-ci bot commented Oct 10, 2024

@raghavendra-talur: All pull requests linked via external trackers have merged:

Bugzilla bug 2280927 has been moved to the MODIFIED state.

In response to this:

Bug 2280927: Backport of upstream PR RamenDR#1573

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@raghavendra-talur raghavendra-talur deleted the rtalur-backport-1573 branch October 10, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants