Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG DFBUGS-1422: vrg: get start time of recover/backup from first velero req #443

Conversation

raghavendra-talur
Copy link

Backport of github.com/ramendr/ramen

Earlier, we assumed that all steps in a workflow sequence are velero requests. However, it is not true anymore when hooks are allowed in a workflow. We get the start time of the job from the first velero request.

Earlier, we assumed that all steps in a workflow sequence are velero
requests. However, it is not true anymore when hooks are allowed in a workflow.
We get the start time of the job from the first velero request.

Co-Authored-by: Annaraya Narasagond <[email protected]>
Signed-off-by: Raghavendra Talur <[email protected]>
(cherry picked from commit 509b2f0)
Now it is required that a backup or a recover workflow has at least one
resource group. Amend the tests for the same.

Co-Authored-by: Annaraya Narasagond <[email protected]>
Signed-off-by: Raghavendra Talur <[email protected]>
(cherry picked from commit 122bdb8)
Copy link

openshift-ci bot commented Jan 31, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: raghavendra-talur

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@raghavendra-talur raghavendra-talur changed the title vrg: get start time of recover/backup from first velero req BUG DFBUGS-1422: vrg: get start time of recover/backup from first velero req Jan 31, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference labels Jan 31, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 31, 2025

@raghavendra-talur: This pull request references [Jira Issue DFBUGS-1422](https://issues.redhat.com//browse/DFBUGS-1422), which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (odf-4.18) matches configured target version for branch (odf-4.18)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @keesturam

In response to this:

Backport of github.com/ramendr/ramen

Earlier, we assumed that all steps in a workflow sequence are velero requests. However, it is not true anymore when hooks are allowed in a workflow. We get the start time of the job from the first velero request.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link

openshift-ci bot commented Jan 31, 2025

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: keesturam.

Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@raghavendra-talur: This pull request references [Jira Issue DFBUGS-1422](https://issues.redhat.com//browse/DFBUGS-1422), which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (odf-4.18) matches configured target version for branch (odf-4.18)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @keesturam

In response to this:

Backport of github.com/ramendr/ramen

Earlier, we assumed that all steps in a workflow sequence are velero requests. However, it is not true anymore when hooks are allowed in a workflow. We get the start time of the job from the first velero request.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@raghavendra-talur raghavendra-talur merged commit d39c16a into red-hat-storage:release-4.18 Feb 2, 2025
21 of 22 checks passed
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 2, 2025

@raghavendra-talur: [Jira Issue DFBUGS-1422](https://issues.redhat.com//browse/DFBUGS-1422): All pull requests linked via external trackers have merged:

[Jira Issue DFBUGS-1422](https://issues.redhat.com//browse/DFBUGS-1422) has been moved to the MODIFIED state.

In response to this:

Backport of github.com/ramendr/ramen

Earlier, we assumed that all steps in a workflow sequence are velero requests. However, it is not true anymore when hooks are allowed in a workflow. We get the start time of the job from the first velero request.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@raghavendra-talur raghavendra-talur deleted the rtalur-backport-1757 branch February 2, 2025 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug jira/valid-reference
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants