Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for RUNNER_NAME #36

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add support for RUNNER_NAME #36

wants to merge 2 commits into from

Conversation

jkupferer
Copy link

@jkupferer jkupferer commented Aug 30, 2024 •
edited
Loading

Description

Add support to set the GitHub runner name by use of RUNNER_NAME environment variable while maintaining default to hostname.

Related Issue(s)

#35

Checklist

  • [x ] This PR includes a documentation change
  • This PR does not need a documentation change
  • This PR includes test changes
  • [ x] This PR's changes are already tested
  • This change is not user-facing
  • This change is a patch change
  • [ x] This change is a minor change
  • This change is a major (breaking) change

Changes made

Update register.sh to default the runner name to environment variable RUNNER_NAME with default to hostname.

@jduimovich jduimovich self-requested a review September 11, 2024 12:46
jduimovich
jduimovich approved these changes Sep 11, 2024
View reviewed changes
Copy link
Member

@jduimovich jduimovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and is backwards compatible, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jduimovich jduimovich jduimovich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jkupferer @jduimovich