Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align chart name with openshift-charts #23

Merged
merged 8 commits into from
Nov 15, 2024

Conversation

thepetk
Copy link
Collaborator

@thepetk thepetk commented Nov 14, 2024

What does this PR do?:

It fixes the naming for the chart making it identical to what we have in openshift-helm-charts/charts#1669

Which issue(s) this PR fixes:

N/A

PR acceptance criteria:

Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened and linked to this PR, if they are not in the PR scope due to various constraints.

  • Tested and Verified
  • Documentation (READMEs, Product Docs, Blogs, Education Modules, etc.)

How to test changes / Special notes to the reviewer:

@thepetk thepetk changed the title Add more context about release name and application namespace Add more context about release name and application namespace and align chart name with openshift-charts Nov 14, 2024
@thepetk thepetk changed the title Add more context about release name and application namespace and align chart name with openshift-charts Align chart name with openshift-charts Nov 15, 2024
@thepetk
Copy link
Collaborator Author

thepetk commented Nov 15, 2024

I'll address the release namespace suggestion on a new PR

@thepetk thepetk requested a review from coreydaley November 15, 2024 14:44
@thepetk thepetk requested a review from Jdubrick November 15, 2024 15:17
Copy link
Contributor

@Jdubrick Jdubrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@thepetk thepetk merged commit 0d63b49 into redhat-ai-dev:main Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants