-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align chart name with openshift-charts #23
Merged
thepetk
merged 8 commits into
redhat-ai-dev:main
from
thepetk:feat/clarify_release_namespace
Nov 15, 2024
Merged
Align chart name with openshift-charts #23
thepetk
merged 8 commits into
redhat-ai-dev:main
from
thepetk:feat/clarify_release_namespace
Nov 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thepetk
changed the title
Add more context about release name and application namespace
Add more context about release name and application namespace and align chart name with openshift-charts
Nov 14, 2024
Signed-off-by: thepetk <[email protected]>
coreydaley
reviewed
Nov 14, 2024
coreydaley
reviewed
Nov 14, 2024
coreydaley
reviewed
Nov 14, 2024
thepetk
changed the title
Add more context about release name and application namespace and align chart name with openshift-charts
Align chart name with openshift-charts
Nov 15, 2024
I'll address the release namespace suggestion on a new PR |
Jdubrick
reviewed
Nov 15, 2024
Co-authored-by: Jordan Dubrick <[email protected]>
Co-authored-by: Jordan Dubrick <[email protected]>
Jdubrick
approved these changes
Nov 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?:
It fixes the naming for the chart making it identical to what we have in openshift-helm-charts/charts#1669
Which issue(s) this PR fixes:
N/A
PR acceptance criteria:
Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened and linked to this PR, if they are not in the PR scope due to various constraints.
How to test changes / Special notes to the reviewer: