Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Go to v1.24.0 #254

Merged
merged 1 commit into from
Feb 13, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions .github/workflows/pre-main.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,24 +16,24 @@ jobs:
runs-on: ubuntu-22.04

steps:
- name: Set up Go 1.23
- name: Check out code into the Go module directory
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
with:
ref: ${{ github.sha }}

- name: Set up Go 1.24
uses: actions/setup-go@f111f3307d8850f501ac008e886eec1fd1932a34 # v5.3.0
with:
go-version: 1.23.6
go-version-file: go.mod

- name: Disable default go problem matcher
run: echo "::remove-matcher owner=go::"

- name: Check out code into the Go module directory
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
- name: Golangci-lint
uses: golangci/golangci-lint-action@v6
with:
ref: ${{ github.sha }}

- name: Install golangci-lint
run: make install-lint

- name: make lint
run: make lint
version: v1.64
args: --timeout 10m0s

- name: make vet
run: make vet
7 changes: 0 additions & 7 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -12,16 +12,9 @@ else
GOBIN=$(shell go env GOBIN)
endif

# Variables
GOLANGCI_VERSION=v1.64.3

vet:
go vet ${GO_PACKAGES}

# Install golangci-lint
install-lint:
curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b ${GO_PATH}/bin ${GOLANGCI_VERSION}

# Run configured linters
lint:
golangci-lint run --timeout 10m0s
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/redhat-best-practices-for-k8s/privileged-daemonset

go 1.23.6
go 1.24.0

require (
k8s.io/api v0.32.1
Expand Down
Loading