Mine page: add the option to add expense #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShellyGolden
force-pushed
the
add_expense_branch
branch
2 times, most recently
from
555f574 to
06dc638
Compare
ShellyGolden
added
Blocked by another PR
ShellyGolden
force-pushed
the
add_expense_branch
branch
3 times, most recently
from
eed98fc to
57124fe
Compare
ShellyGolden
force-pushed
the
add_expense_branch
branch
4 times, most recently
from
2f38a2d to
e331ca9
Compare
ShellyGolden
added
Ready for a review
and removed
Status/In-Progress
Tests are missing
labels
ShellyGolden
requested review from
ronyyosef,
LiorKGOW,
shlior7,
adiabramovitch,
svatares and
Yoavsc129
LiorKGOW
suggested changes
Apr 22, 2022
There was a problem hiding this comment.
GJ! @ShellyGolden
I have left a comment
Looks awesome :)
Don't forget to remove the tests from your TODO list 👍
LiorKGOW
reviewed
Apr 22, 2022
LiorKGOW
reviewed
Apr 22, 2022
ShellyGolden
force-pushed
the
add_expense_branch
branch
2 times, most recently
from
e876f08 to
f0f720e
Compare
ShellyGolden
force-pushed
the
add_expense_branch
branch
from
6062929 to
f06ea4f
Compare
I deleted them |
ShellyGolden
force-pushed
the
add_expense_branch
branch
from
f06ea4f to
7e20442
Compare
|
please rebase |
ShellyGolden
force-pushed
the
add_expense_branch
branch
2 times, most recently
from
b3992eb to
a3f5edc
Compare
shlior7
force-pushed
the
add_expense_branch
branch
2 times, most recently
from
97f9011 to
28a8f10
Compare
|
@ShellyGolden I rebase and fixed some conflicts, |
No, this PR is ready to merge |
ShellyGolden
force-pushed
the
add_expense_branch
branch
2 times, most recently
from
b6fcf6e to
bac1e60
Compare
Yoavsc129
approved these changes
May 24, 2022
Omeramsc
requested changes
May 24, 2022
ShellyGolden
force-pushed
the
add_expense_branch
branch
2 times, most recently
from
06b9305 to
89356e2
Compare
ShellyGolden
force-pushed
the
add_expense_branch
branch
from
89356e2 to
03a4d67
Compare
- add button of the option - add the view of add expense - add tests for the option to add expense to house Signed-off-by: Shelly Golden <[email protected]>
ShellyGolden
force-pushed
the
add_expense_branch
branch
from
03a4d67 to
69d378f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relevant issue #70
negative amount:
empty description:
