-
Notifications
You must be signed in to change notification settings - Fork 28
Fix install_devconsole for mac. #216
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @pmacik. Thanks for your PR. I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
|
@sbose78 I've just tried in the macos (in VBox) and it works: ibm-p8-kvm-03-guest-02:hack pmacik$ head -n 10 install_devconsole/consoledeveloper.sh
#!/bin/bash
set -x
function pathname() {
DIR="${1%/*}"
(cd "$DIR" && echo "$(pwd -P)")
}
cd $(pathname $0)
oc apply -f ./yamls/unmanage.yaml ibm-p8-kvm-03-guest-02:hack pmacik$ ./install_devconsole/consoledeveloper.sh
++ pathname ./install_devconsole/consoledeveloper.sh
++ DIR=./install_devconsole
++ cd ./install_devconsole
+++ pwd -P
++ echo /Users/pmacik/Downloads/devconsole-operator-fix-install-devconsole-mac/hack/install_devconsole
+ cd /Users/pmacik/Downloads/devconsole-operator-fix-install-devconsole-mac/hack/install_devconsole
+ oc apply -f ./yamls/unmanage.yaml
clusterversion.config.openshift.io/version unchanged
... Are you sure you tried it with the patch? :) |
No description provided.