Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Non-blocking LSP requests for inlay hints and color hints #836

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: Non-blocking LSP requests for inlay hints and color hints #836

wants to merge 1 commit into from

Conversation

FalsePattern
Copy link
Contributor

Proposed solution for #835

@FalsePattern FalsePattern force-pushed the inlayhint-edt-block-fix branch from 1e2ff2b to 803ec6a Compare February 11, 2025 19:26
@FalsePattern
Copy link
Contributor Author

FalsePattern commented Feb 11, 2025 •
edited by angelozerr
Loading

I've updated the code to use an overload for the waitUntilDone function instead, and replaced the pendingFutures system with sets. I'm not sure what you mean by "editor data".

editor.putUserData(INLAY_HINTS_PENDING_FUTURES_KEY pendingFutures)

Set<CompletionFuture> pendingFutures = editor.getUserData(INLAY_HINTS_PENDING_FUTURES_KEY)

@FalsePattern FalsePattern force-pushed the inlayhint-edt-block-fix branch from 803ec6a to deb3752 Compare February 11, 2025 20:36
@FalsePattern FalsePattern marked this pull request as ready for review February 11, 2025 20:39
@angelozerr angelozerr added this to the 0.11.0 milestone Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angelozerr angelozerr angelozerr left review comments

Assignees
No one assigned
Labels
color enhancement New feature or request inlayhint performance
Projects
Java Tooling
Status: Pending review
Milestone
0.11.0
Development

Successfully merging this pull request may close these issues.
2 participants
@FalsePattern @angelozerr