Skip to content
This repository has been archived by the owner on Jun 26, 2024. It is now read-only.

feature: add RedisCluster CRD to supported Service Binding types #1407

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Keanu73
Copy link

@Keanu73 Keanu73 commented Mar 12, 2023

Changes

This adds the RedisCluster CRD type to the supported Service Binding registry bindings.

/kind enhancement

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs
    included if any changes are user facing
  • Tests
    included if any functionality added or changed. For bugfixes please include tests that can catch regressions
  • All acceptance test scenarios included in the PR which verifies a bugfix or a requested feature reported by a non-member are tagged with @external-feedback tag.
  • Follows the commit message standard

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 12, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign pmacik for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 12, 2023

Hi @Keanu73. Thanks for your PR.

I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Mar 13, 2023

Codecov Report

Merging #1407 (fa73461) into master (2bd54e6) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1407   +/-   ##
=======================================
  Coverage   58.21%   58.21%           
=======================================
  Files          35       35           
  Lines        3011     3011           
=======================================
  Hits         1753     1753           
  Misses       1090     1090           
  Partials      168      168           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2bd54e6...fa73461. Read the comment docs.

@sadlerap
Copy link
Contributor

Thanks for the PR!

Could you add an acceptance test for this to test/acceptance/features/supportExistingOperatorBackedServices.feature? We want to make sure we don't break this accidentially.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants