apply code review suggestions

- move scope switching to java status. - move the setting to code navigation category. Signed-off-by: Gayan Perera <[email protected]>
redhat-developer · Sep 17, 2024 · 0c8d064 · 0c8d064
1 parent 31de294
commit 0c8d064
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 45 deletions.
diff --git a/src/extension.ts b/src/extension.ts
@@ -40,7 +40,6 @@ import { loadSupportedJreNames } from './jdkUtils';
 import { BuildFileSelector, PICKED_BUILD_FILES, cleanupWorkspaceState } from './buildFilesSelector';
 import { pasteFile } from './pasteAction';
 import { ServerStatusKind } from './serverStatus';
-import { searchScopeBarProvider } from './searchScopeStatusBarProvider';
 
 const syntaxClient: SyntaxLanguageClient = new SyntaxLanguageClient();
 const standardClient: StandardLanguageClient = new StandardLanguageClient();
@@ -549,13 +548,12 @@ export async function activate(context: ExtensionContext): Promise<ExtensionAPI>
 			context.subscriptions.push(commands.registerCommand(Commands.CHANGE_JAVA_SEARCH_SCOPE, async () => {
 				const selection = await window.showQuickPick(["all", "main"], {
 					canPickMany: false,
-					placeHolder: "Choose a Java Search Scope",
+					placeHolder: `Current: ${workspace.getConfiguration().get("java.search.scope")}`,
 				});
 				if(selection) {
-					workspace.getConfiguration().update("java.search.scope", selection, false).then(() => searchScopeBarProvider.update());
+					workspace.getConfiguration().update("java.search.scope", selection, false);
 				}
 			}));
-			context.subscriptions.push(searchScopeBarProvider);
 
 			context.subscriptions.push(snippetCompletionProvider.initialize());
 			context.subscriptions.push(serverStatusBarProvider);

diff --git a/src/searchScopeStatusBarProvider.ts b/src/searchScopeStatusBarProvider.ts