Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add capability to select projects to be imported #3356

Merged
merged 4 commits into from
Nov 22, 2023
Merged

Add capability to select projects to be imported #3356

merged 4 commits into from
Nov 22, 2023

Conversation

jdneo
Copy link
Collaborator

@jdneo jdneo commented Oct 24, 2023

snjeza
snjeza previously approved these changes Oct 24, 2023
View reviewed changes
@jdneo jdneo marked this pull request as draft October 26, 2023 08:56
@jdneo jdneo changed the title Add capability to select projects to be imported [WIP] Add capability to select projects to be imported Oct 26, 2023
@jdneo jdneo force-pushed the cs/project-picker branch 2 times, most recently from ec9c125 to 91de44f Compare October 27, 2023 03:45
@jdneo
Copy link
Collaborator Author

jdneo commented Oct 27, 2023

Some major changes are made according to the feedback in last meeting:

  • The regular expression is removed from the contribution point
  • Now the setting java.import.configurationFileCollectionMode contains 3 options: manual, automatic and askUser
  • Since currently only maven importer supports partially import sub modules. So, the project picker will only search for pom files.

@jdneo jdneo marked this pull request as ready for review October 27, 2023 05:24
@jdneo jdneo changed the title [WIP] Add capability to select projects to be imported Add capability to select projects to be imported Oct 27, 2023
@jdneo jdneo force-pushed the cs/project-picker branch from 11dd112 to 6b85b7f Compare November 9, 2023 02:50
testforstephen
testforstephen reviewed Nov 10, 2023
View reviewed changes
src/buildFilesSelector.ts Outdated Show resolved Hide resolved
src/buildFilesSelector.ts Show resolved Hide resolved
src/buildFilesSelector.ts Outdated Show resolved Hide resolved
src/settings.ts Show resolved Hide resolved
src/languageStatusItemFactory.ts Outdated Show resolved Hide resolved
src/languageStatusItemFactory.ts Outdated Show resolved Hide resolved
@snjeza
Copy link
Contributor

snjeza commented Nov 10, 2023 •
edited
Loading

@jdneo You should respect java.import.exclusions when offering a project list. See #2537 (comment) for an example.

@snjeza snjeza self-requested a review November 10, 2023 17:50
@jdneo
Copy link
Collaborator Author

jdneo commented Nov 11, 2023

@jdneo You should respect java.import.exclusions when offering a project list. See #2537 (comment) for an example.

Yes it's taken into account:

vscode-java/src/buildFilesSelector.ts

Line 14 in 6b85b7f

this.exclusionGlobPattern = getExclusionGlobPattern(["**/target/**", "**/bin/**", "**/build/**"]);

@snjeza
Copy link
Contributor

snjeza commented Nov 11, 2023

Yes it's taken into account:

Could you try the example at #2537 (comment)? It includes the ! pattern (inclusions) - #1084

@jdneo
Copy link
Collaborator Author

jdneo commented Nov 13, 2023

Could you try the example at #2537 (comment)? It includes the ! pattern (inclusions) - #1084

Done.

testforstephen
testforstephen reviewed Nov 20, 2023
View reviewed changes
package.json Outdated Show resolved Hide resolved
@jdneo jdneo force-pushed the cs/project-picker branch from 9bd874c to af5953a Compare November 20, 2023 08:09
jdneo added 2 commits November 21, 2023 11:13
@jdneo
Support to manually select Maven pom files to import
da78c6b 
- A new setting `java.import.configurationFileCollectionMode` is added to configure
  whether manually build file selection is required before import.
- A new contribution point `javaBuildTypes` is introduced, and will be used when
  the build files need to be manually selected.

Signed-off-by: Sheng Chen <[email protected]>
@jdneo
Address comments
64edcaf 
Signed-off-by: Sheng Chen <[email protected]>
testforstephen
testforstephen reviewed Nov 21, 2023
View reviewed changes
package.json Outdated Show resolved Hide resolved
@jdneo jdneo force-pushed the cs/project-picker branch from af5953a to a14fd7e Compare November 21, 2023 03:19
testforstephen
testforstephen reviewed Nov 21, 2023
View reviewed changes
src/settings.ts Outdated Show resolved Hide resolved
src/buildFilesSelector.ts Outdated Show resolved Hide resolved
@jdneo
Address comments
81ff12c 
Signed-off-by: Sheng Chen <[email protected]>
@jdneo jdneo merged commit 86bf3ae into redhat-developer:master Nov 22, 2023
2 checks passed
@jdneo jdneo deleted the cs/project-picker branch November 22, 2023 08:07
@rgrunber rgrunber added this to the End November 2023 milestone Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@testforstephen testforstephen testforstephen approved these changes

@snjeza snjeza snjeza approved these changes

@fbricon fbricon Awaiting requested review from fbricon

@rgrunber rgrunber Awaiting requested review from rgrunber

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
End November 2023
Development

Successfully merging this pull request may close these issues.
4 participants
@jdneo @snjeza @testforstephen @rgrunber