Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix escape characters within textblock #3412

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Fix escape characters within textblock #3412

merged 1 commit into from
Dec 5, 2023

Conversation

hopehadfield
Copy link
Contributor

Fixes #3384

Before:
Screenshot from 2023-12-04 15-41-28

After:
Screenshot from 2023-12-04 15-39-43

@rgrunber rgrunber modified the milestone: End December 2023 Dec 5, 2023
@rgrunber
Copy link
Member

rgrunber commented Dec 5, 2023 •
edited
Loading

It's worth noting that \"""""" ([escaped triple quote][end of text block]) doesn't even compile so no need to handle things like that.

@rgrunber rgrunber merged commit f09b712 into redhat-developer:master Dec 5, 2023
2 checks passed
@hopehadfield hopehadfield deleted the 3384-textblock branch December 12, 2023 16:33
@hopehadfield hopehadfield mentioned this pull request Dec 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgrunber rgrunber rgrunber left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ending text blocks / multiline strings in quotes ruins syntax highlightion
2 participants
@hopehadfield @rgrunber