Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keybinding & setting to perform cleanup actions manually. #3451

Merged
merged 1 commit into from
Feb 3, 2024

Conversation

hopehadfield
Copy link
Contributor

@hopehadfield hopehadfield commented Jan 4, 2024

Implements request in #3424.

Requires eclipse-jdtls/eclipse.jdt.ls#3010.

package.json Outdated Show resolved Hide resolved
src/sourceAction.ts Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/protocol.ts Outdated Show resolved Hide resolved
Copy link
Member

@rgrunber rgrunber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. Just some minor things. I think this part is ready.

src/sourceAction.ts Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.nls.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@hopehadfield hopehadfield force-pushed the 3424-cleanup branch 2 times, most recently from 0bbc596 to 332d447 Compare February 2, 2024 20:37
@rgrunber rgrunber changed the title Introduces keybinding and setting to perform typical on-save cleanup actions manually Add keybinding & setting to perform cleanup actions manually. Feb 3, 2024
@rgrunber rgrunber merged commit bcae80e into redhat-developer:master Feb 3, 2024
2 checks passed
@hopehadfield hopehadfield deleted the 3424-cleanup branch April 23, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants