-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add keybinding & setting to perform cleanup actions manually. #3451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hopehadfield
force-pushed
the
3424-cleanup
branch
from
January 8, 2024 21:03
30db9dd
to
b1a4972
Compare
rgrunber
reviewed
Jan 17, 2024
rgrunber
reviewed
Jan 17, 2024
rgrunber
reviewed
Jan 17, 2024
rgrunber
reviewed
Jan 17, 2024
hopehadfield
force-pushed
the
3424-cleanup
branch
from
January 17, 2024 21:28
b1a4972
to
3d5f6c6
Compare
rgrunber
approved these changes
Jan 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good. Just some minor things. I think this part is ready.
rgrunber
reviewed
Jan 23, 2024
hopehadfield
force-pushed
the
3424-cleanup
branch
3 times, most recently
from
January 30, 2024 15:57
e5c3767
to
74f0d52
Compare
rgrunber
force-pushed
the
3424-cleanup
branch
from
February 2, 2024 16:52
74f0d52
to
a4d4c2a
Compare
rgrunber
reviewed
Feb 2, 2024
hopehadfield
force-pushed
the
3424-cleanup
branch
2 times, most recently
from
February 2, 2024 20:37
0bbc596
to
332d447
Compare
rgrunber
force-pushed
the
3424-cleanup
branch
from
February 3, 2024 03:16
332d447
to
d7c9a48
Compare
rgrunber
changed the title
Introduces keybinding and setting to perform typical on-save cleanup actions manually
Add keybinding & setting to perform cleanup actions manually.
Feb 3, 2024
Signed-off-by: Hope Hadfield <[email protected]>
rgrunber
force-pushed
the
3424-cleanup
branch
from
February 3, 2024 03:20
d7c9a48
to
beb5107
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements request in #3424.
Requires eclipse-jdtls/eclipse.jdt.ls#3010.