Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom Lombok 1.18.31 snapshot into lombok folder. #3456

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

rgrunber
Copy link
Member

For testing purposes, make sure to clean out any older (non lombok-1.18.31.jar) versions from your lombok/ folder. Only remaining issue is I feel this should be named something other than 1.18.31.

@fbricon
Copy link
Collaborator

fbricon commented Jan 10, 2024

rename it 1.18.31-3565

@rgrunber rgrunber self-assigned this Jan 10, 2024
@rgrunber
Copy link
Member Author

rgrunber commented Jan 10, 2024

rename it 1.18.31-3565

const lombokJarRegex = /lombok-\d+.*\.jar$/;

Would need to modify that line. Probably /lombok-\d+.*-\d+.jar$/; . So it isn't part of any version calculation.

Update: Nevermind, change not needed.

Copy link
Contributor

@snjeza snjeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works fine.

@rgrunber rgrunber merged commit d964041 into redhat-developer:master Jan 10, 2024
2 checks passed
@rgrunber rgrunber deleted the fix-3454 branch January 10, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

(Lombok) annotations with arguments show an error in releases after 1.25.1
3 participants