Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

on-prem-update-485-take2 #501

Merged
merged 1 commit into from
Jul 17, 2024
Merged

on-prem-update-485-take2 #501

merged 1 commit into from
Jul 17, 2024

Conversation

dfitzmau
Copy link
Contributor

@dfitzmau dfitzmau commented Jul 11, 2024 •
edited
Loading

Address issue #485

Preview link

Vale update also needed for "on-premise" in the context of OCP but I'll make this update in a separate project.

This PR takes over from #487

@dfitzmau dfitzmau added the Glossary entry Topics that add or modify glossary entries label Jul 11, 2024
bergerhoffer
bergerhoffer approved these changes Jul 11, 2024
View reviewed changes
Copy link
Collaborator

@bergerhoffer bergerhoffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sbmetz
sbmetz approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@sbmetz sbmetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ndeevy
ndeevy approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@ndeevy ndeevy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lahinson
lahinson approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@lahinson lahinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lahinson lahinson merged commit a642b49 into redhat-documentation:main Jul 17, 2024
1 check passed
@dfitzmau dfitzmau mentioned this pull request Jul 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lahinson lahinson lahinson approved these changes

@ndeevy ndeevy ndeevy approved these changes

@sbmetz sbmetz sbmetz approved these changes

@bergerhoffer bergerhoffer bergerhoffer approved these changes

Assignees
No one assigned
Labels
Glossary entry Topics that add or modify glossary entries
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dfitzmau @bergerhoffer @sbmetz @ndeevy @lahinson