Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ONS Tutorial updates #263

Open
wants to merge 38 commits into
base: master
Choose a base branch
from
Open

ONS Tutorial updates #263

wants to merge 38 commits into from

Conversation

dougbtv
Copy link
Member

@dougbtv dougbtv commented Oct 25, 2018

This is... A big pull request. In general, it shouldn't have a super large impact on the core functionality. There's a few things we need from this to move forward as it fixes a couple bugs that we have noticed along the way too.

Happy to either work on fixes herein, or... Fix up as pull requests after the fact. I'll leave that to you guys if you have any preference.

…tup with some shell scripts, only lightly tested
…ates to use non-bridge mode networking (e.g. NAT'd)
…id, includes way to ignore kube version during kubeadm init/join
…rfaces and add custom Kubernetes configurations
…RNING: Could not initially verify that virt-net-device-plugin worked
@ghost ghost assigned dougbtv Oct 25, 2018
@ghost ghost added the state:needs_review label Oct 25, 2018
@leifmadsen
Copy link
Contributor

@dougbtv somewhat related/unrelated, would you mind fixing up the .travis-ci.yml file and making sure the linting is hitting the appropriate files? It would be good to validate that your changes are ansible-lint valid as well...

Copy link
Contributor

@leifmadsen leifmadsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a bunch of work before merging to master.

@@ -195,6 +195,24 @@ kube-node-3 Ready <none> 9m v1.8.3

Everything should be marked as ready. If so, you're good to go!

## Creating a bootstrapped image

Should you need to spin up multiple clusters or otherwise spin up a bunch of VMs for a cluster, it may behoove you to "bootstrap" your VM images so that you don't have to download the dependencies many times. You can create a sort of golden image to use by using the `./playbooks/create-bootstrapped-image.yml` playbook.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation wrapped to 80 chars please...

@@ -0,0 +1,5 @@
#!/bin/bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#!/bin/bash
#!/usr/bin/env bash

@@ -0,0 +1,68 @@
#!/bin/bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#!/bin/bash
#!/usr/bin/env bash

@@ -0,0 +1,12 @@
#!/bin/bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#!/bin/bash
#!/usr/bin/env bash

@@ -0,0 +1,13 @@
#!/bin/bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#!/bin/bash
#!/usr/bin/env bash

chdir: "{{ ansible_env.HOME }}/src/go/src/github.com/zshi-redhat/ehost-device-cni"

- name: Copy Userspace CNI plugin to CNI bin dir
shell: >
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
shell: >
command: >

gpgcheck: no

- name: Install VPP repo
yum:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
yum:
package:


# How do I install the proper VPP version?
- name: Install VPP
yum:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As previously, this is cleaner with the vars approach to allow better dependency resolution with the added benefit that it'll be like 1000 times faster.



- name: Start & Enable VPP
service:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably mean systemd here instead of service.

enabled: yes

- name: Ensure git is installed
yum:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
yum:
package:

@s1061123 s1061123 force-pushed the master branch 9 times, most recently from c75c368 to c8b4850 Compare February 28, 2021 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants