Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement jq templating #379

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Implement jq templating #379

merged 1 commit into from
Oct 20, 2023

Conversation

LaurentGoderre
Copy link
Contributor

No description provided.

@LaurentGoderre LaurentGoderre force-pushed the templating branch 2 times, most recently from a73962a to cd91323 Compare October 6, 2023 14:32
@LaurentGoderre LaurentGoderre changed the title wip: templating Implement jq templating Oct 6, 2023
@LaurentGoderre LaurentGoderre marked this pull request as ready for review October 6, 2023 14:33
yosifkit
yosifkit reviewed Oct 11, 2023
View reviewed changes
Copy link
Contributor

@yosifkit yosifkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dropped a few inline comments.

This PR should add the template checking action that we use in other repos. (this makes sure that a PR that includes template changes, also updates the Dockerfiles so that the build tests are representative of the changes)

versions.sh Outdated Show resolved Hide resolved
apply-templates.sh Outdated Show resolved Hide resolved
versions.sh Outdated Show resolved Hide resolved
versions.sh Outdated Show resolved Hide resolved
versions.sh Outdated Show resolved Hide resolved
versions.sh Outdated Show resolved Hide resolved
versions.sh Outdated Show resolved Hide resolved
@LaurentGoderre LaurentGoderre force-pushed the templating branch 4 times, most recently from d56d096 to ab7703a Compare October 11, 2023 14:16
@LaurentGoderre
Copy link
Contributor Author

All fixed

This was referenced Oct 13, 2023
Closed
Closed
@yosifkit
Copy link
Contributor

Error when evaluating 'strategy' for job 'test'. .github/workflows/ci.yml (Line: 32, Col: 15): Matrix must define at least one vector

Ah, this is missing an update to ./generate-stackbrew-library.sh (so that it can generate what to build test).

yosifkit
yosifkit reviewed Oct 18, 2023
View reviewed changes
Dockerfile-alpine.template
@@ -1,4 +1,4 @@
FROM alpine:3.18
FROM alpine:{{ env.variant | ltrimstr("alpine") }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a future goal would be to combine the Alpine and Debian templates into one to ensure that the common bits and flow remain in sync. This can be a future PR or added to this one 🤷.

@LaurentGoderre
Copy link
Contributor Author

Fixed the bashbrew script

@yosifkit yosifkit merged commit 12e802f into redis:master Oct 20, 2023
10 checks passed
yosifkit added a commit to docker-library/oi-janky-groovy that referenced this pull request Oct 20, 2023
@yosifkit
Update redis to the new pipeline
9de43c1 
See redis/docker-library-redis#379
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Oct 20, 2023
@docker-library-bot
Update redis
01ed159 
Changes:

- redis/docker-library-redis@12e802f: Merge pull request redis/docker-library-redis#379 from LaurentGoderre/templating
- redis/docker-library-redis@c01ba51: Implement jq templating
@LaurentGoderre LaurentGoderre deleted the templating branch October 23, 2023 14:20
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Nov 1, 2023
@docker-library-bot
Update redis
3f3e4bc 
Changes:

- redis/docker-library-redis@1af13e5: Update 7.2 to 7.2.3
- redis/docker-library-redis@12e802f: Merge pull request redis/docker-library-redis#379 from LaurentGoderre/templating
- redis/docker-library-redis@c01ba51: Implement jq templating
@yosifkit yosifkit mentioned this pull request Nov 1, 2023
Merged
@yosifkit yosifkit mentioned this pull request Nov 10, 2023
Merged
@tianon tianon mentioned this pull request Dec 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yosifkit yosifkit yosifkit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LaurentGoderre @yosifkit