Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove eval from docker-entrypoint.sh #415

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Remove eval from docker-entrypoint.sh #415

merged 1 commit into from
Sep 19, 2024

Conversation

adamiBs
Copy link
Collaborator

@adamiBs adamiBs commented Sep 19, 2024

This PR removes usage of eval in our docker-entrypoint.sh and uses set -- with exec instead.

@adamiBs adamiBs changed the base branch from master to release/8.0 September 19, 2024 12:38
@adamiBs
Deprecate usage of eval in docker-entrypoint.sh
c8a2918 
`eval` is riskier due to potential security vulnerabilities and unpredictable behavior when handling arguments.
@adamiBs adamiBs merged commit 1b88507 into redis:release/8.0 Sep 19, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adobrzhansky adobrzhansky adobrzhansky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamiBs @adobrzhansky