feat: make it possible to choose time display format in player #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkonsti
approved these changes
Sep 9, 2024
packages/player-react/src/utils.ts
Outdated
| .toString() | ||
| .padStart(3, '0'); | ||
|
|
||
| console.log('timedisplayformat', timeDisplayFormat); |
| return `${toFormattedTime(timeInSeconds)} / ${toFormattedTime( | ||
| absoluteTimeInSeconds, | ||
| )}`; | ||
| return `${toFormattedTime(timeInSeconds)} / ${toFormattedTime(absoluteTimeInSeconds)}`; |
There was a problem hiding this comment.
This seems to recursively call itself. Is this code even reachable? If not, you can either just return 'MM:SS' as the default case, or throw an "Unreachable" error. I think I'd prefer moving the MM:SS case down and removing that if condition so it becomes the default return.
There was a problem hiding this comment.
no, the toFormattedTime function is defined inside of getFormattedTime. The last return statement always applies. You had built it that way initially so I just kept it :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.