Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ability to use additional fields for volume mounts #97

Merged
merged 3 commits into from
Aug 15, 2024

Conversation

trahim
Copy link
Contributor

@trahim trahim commented Jun 20, 2024

No description provided.

@CLAassistant
Copy link

CLAassistant commented Jun 20, 2024

CLA assistant check
All committers have signed the CLA.

@charlie-haley
Copy link
Collaborator

Hey @trahim, sorry for the delay in looking at this! Could you add some tests into the /tests folder as part of this PR? You should be able to make use the existing Deployment tests - https://github.com/redpanda-data/redpanda-connect-helm-chart/blob/main/tests/deployment_test.yaml

@trahim
Copy link
Contributor Author

trahim commented Jul 31, 2024

Hey @charlie-haley added some in now

@charlie-haley
Copy link
Collaborator

Fixes #103

Copy link
Collaborator

@charlie-haley charlie-haley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the PR @trahim

@charlie-haley charlie-haley merged commit 39d8be4 into redpanda-data:main Aug 15, 2024
2 checks passed
@bentatham
Copy link

Any chance we can get a new release to include this? Or a timeline of when that would be coming?

@trahim
Copy link
Contributor Author

trahim commented Aug 16, 2024

Looking at the GH job looks like I also needed to bump up the version of the Chart.yaml(my bad) as a release was attempted, can create a PR bumping or leave to you @charlie-haley ?

@trahim trahim deleted the patch-1 branch August 16, 2024 15:11
@charlie-haley
Copy link
Collaborator

Hey, I'm currently chatting to Redpanda about whether the chart will be moved into their Helm Repo or stay in the benthosdev one. So I'm currently holding off on the release until then.

Worst case scenario I'll do a release early next week to the current Helm Repo.

@bentatham
Copy link

Is there any objection if I submit a PR to allow templates in the values of extraVolumes and extraVolumeMounts (using tpl), so we can reference other values from within the values file as part of those? (eg use an another value for the subPath).

@trahim
Copy link
Contributor Author

trahim commented Aug 23, 2024

Any updates on a new release @charlie-haley ?

@trahim
Copy link
Contributor Author

trahim commented Sep 16, 2024

Any chance of getting a release here @charlie-haley ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants