-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding ability to use additional fields for volume mounts #97
Conversation
Hey @trahim, sorry for the delay in looking at this! Could you add some tests into the |
Hey @charlie-haley added some in now |
Fixes #103 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the PR @trahim
Any chance we can get a new release to include this? Or a timeline of when that would be coming? |
Looking at the GH job looks like I also needed to bump up the version of the |
Hey, I'm currently chatting to Redpanda about whether the chart will be moved into their Helm Repo or stay in the benthosdev one. So I'm currently holding off on the release until then. Worst case scenario I'll do a release early next week to the current Helm Repo. |
Is there any objection if I submit a PR to allow templates in the values of extraVolumes and extraVolumeMounts (using |
Any updates on a new release @charlie-haley ? |
Any chance of getting a release here @charlie-haley ? |
No description provided.