Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bazel: remove seastar fortify patch #25204

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

travisdowns
Copy link
Member

This fix has been integrated in our 25.1.x fork in

adf1c04c379216e1dc243ef3dad146d322a51b96

so we no longer need the the patch.

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.3.x
  • v24.2.x
  • v24.1.x

Release Notes

  • none

dotnwat
dotnwat previously approved these changes Feb 27, 2025
rockwotj
rockwotj previously approved these changes Feb 27, 2025
Copy link
Contributor

@rockwotj rockwotj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to run bazel mod deps

@dotnwat
Copy link
Member

dotnwat commented Feb 27, 2025

hmm, looks like it needs the lock file changes committed too

@travisdowns
Copy link
Member Author

Need to run bazel mod deps

Oops yes. Any idea why this never shows for me locally? I.e., locally this passes.

This fix has been integrated in our 25.1.x fork in

adf1c04c379216e1dc243ef3dad146d322a51b96

so we no longer need the the patch.
@travisdowns travisdowns dismissed stale reviews from rockwotj and dotnwat via 5b68663 February 27, 2025 15:04
@travisdowns travisdowns force-pushed the td-remove-fortify-sesatar-patch branch from 60c76ea to 5b68663 Compare February 27, 2025 15:04
@rockwotj
Copy link
Contributor

Need to run bazel mod deps

Oops yes. Any idea why this never shows for me locally? I.e., locally this passes.

https://github.com/redpanda-data/vtools/commit/916ab6ed4eaf1c13c78687a79528d4eab85e25cc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants