Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gha/promote: fix trigger promote action #25207

Merged
merged 3 commits into from
Feb 27, 2025
Merged

gha/promote: fix trigger promote action #25207

merged 3 commits into from
Feb 27, 2025

Conversation

andrewhsu
Copy link
Member

@andrewhsu andrewhsu commented Feb 27, 2025 •
edited by jira bot
Loading

jira: DEVPROD-2679

The triggered buildkite pipeline actions are failing because PIPELINE_ACTION is not set. This PR ensures the env var is set.

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.3.x
  • v24.2.x
  • v24.1.x

Release Notes

  • none

@andrewhsu
gha/promote: pin run on ubuntu 24.04
81471c9 
No functionality change.

Protect against future `ubuntu-latest` breaking changes.
@andrewhsu
gha/promote: update to latest buildkite/trigger-pipeline-action
47fe54b 
No functionality change expected.

See changes:
buildkite/trigger-pipeline-action@v2.0.0...v2.3.0
@andrewhsu
gha/promote: use PIPELINE_ACTION=promote-from-staging
ad02623 
The PIPELINE_ACTION is the expected driving env var for the buildkite
dynamic pipeline.
@andrewhsu andrewhsu marked this pull request as ready for review February 27, 2025 19:36
@andrewhsu andrewhsu requested a review from a team as a code owner February 27, 2025 19:36
@andrewhsu andrewhsu requested review from ivotron and removed request for a team February 27, 2025 19:36
@andrewhsu andrewhsu enabled auto-merge February 27, 2025 19:37
@andrewhsu andrewhsu requested review from gousteris and rpdevmp and removed request for ivotron February 27, 2025 19:37
rpdevmp
rpdevmp approved these changes Feb 27, 2025
View reviewed changes
Copy link
Contributor

@rpdevmp rpdevmp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewhsu andrewhsu merged commit 59f8054 into dev Feb 27, 2025
12 checks passed
@andrewhsu andrewhsu deleted the DEVPROD-2679-fix-promote branch February 27, 2025 20:14
@vbotbuildovich
Copy link
Collaborator

/backport v24.3.x

@vbotbuildovich
Copy link
Collaborator

/backport v24.2.x

@vbotbuildovich
Copy link
Collaborator

/backport v24.1.x

@vbotbuildovich vbotbuildovich mentioned this pull request Feb 27, 2025
Merged
@vbotbuildovich
Copy link
Collaborator

Failed to create a backport PR to v24.2.x branch. I tried:

git remote add upstream https://github.com/redpanda-data/redpanda.git
git fetch --all
git checkout -b backport-pr-25207-v24.2.x-353 remotes/upstream/v24.2.x
git cherry-pick -x 81471c9332 47fe54b8c7 ad026230e3

Workflow run logs.

@vbotbuildovich
Copy link
Collaborator

Failed to create a backport PR to v24.1.x branch. I tried:

git remote add upstream https://github.com/redpanda-data/redpanda.git
git fetch --all
git checkout -b backport-pr-25207-v24.1.x-312 remotes/upstream/v24.1.x
git cherry-pick -x 81471c9332 47fe54b8c7 ad026230e3

Workflow run logs.

This was referenced Feb 27, 2025
Open
Open
This was referenced Feb 27, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rpdevmp rpdevmp rpdevmp approved these changes

@gousteris gousteris Awaiting requested review from gousteris

Assignees
No one assigned
Labels
area/build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewhsu @vbotbuildovich @rpdevmp