Merge pull request #29 from reeflective/dev

Fix recursive command filtering

commands/readline/set.go

@@ -15,12 +15,10 @@ import (
 	"github.com/reeflective/readline/inputrc"
 )
 
-var (
-	// We here must assume that all bind changes during the lifetime
-	// of the binary are all made by a single readline application.
-	// This config only stores the vars/binds that have been changed.
-	cfgChanged = inputrc.NewConfig()
-)
+// We here must assume that all bind changes during the lifetime
+// of the binary are all made by a single readline application.
+// This config only stores the vars/binds that have been changed.
+var cfgChanged = inputrc.NewConfig()
 
 // Set returns a command named `set`, for manipulating readline global options.
 func Set(shell *readline.Shell) *cobra.Command {

menu.go

@@ -215,7 +215,6 @@ func (m *Menu) CheckIsAvailable(cmd *cobra.Command) error {
 		"cmd":     cmd,
 		"filters": filters,
 	})
-
 	if err != nil {
 		return err
 	}
@@ -245,7 +244,12 @@ func (m *Menu) ActiveFiltersFor(cmd *cobra.Command) []string {
 		}
 	}
 
-	return filters
+	if len(filters) > 0 {
+		return filters
+	}
+
+	// Any parent that is hidden make its whole subtree hidden also.
+	return m.ActiveFiltersFor(cmd.Parent())
 }
 
 // SetErrFilteredCommandTemplate sets the error template to be used

run.go

@@ -146,7 +146,7 @@ func (c *Console) execute(menu *Menu, args []string, async bool) (err error) {
 	// Find the target command: if this command is filtered, don't run it.
 	target, _, _ := cmd.Find(args)
 
-	if err := menu.CheckIsAvailable(target); err != nil {
+	if err = menu.CheckIsAvailable(target); err != nil {
 		return err
 	}