Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow multiple manufacturer specific data #2

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

luisfelrib
Copy link

this PR adds support for multiple manufacturer specific data.

The current behaviour if the advertisement has multiple manufacturer specific data is always rewrite with the last one.

This is not desirable in our situation. We have seen beacons with multiple manufacturer specific data.

This PR changes the interface for the manufacturer specific data for it to be a list of objects instead of just the last object. The list of objects contais all the manufacturer specific data.

An example of payload with multiple manufacturer specific data we captured is:

4024689e190491e00201061aff4c000215e2c56db5dffb48d2b060d0f5a71096e000000001c5020a00041653514307ff000000540000

@jeffyactive
Copy link
Member

Thanks for the PR @luisfelrib. We've never encountered a device that sends multiple manufacturer specific data in a single packet, would be curious to know more about that device so we can add to Sniffypedia and make an example in the web version of advlib.

The example you've provided, however, does not seem to represent a valid BLE packet as it is over 37 bytes. We propose that we clarify the multiple manufacturer specific data case first and then update the code in consequence. Please advise on the above, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants