Localizable #158
Open
Localizable #158
+35
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could we hook into the |
|
Does the reloader works for this change in dev? |
|
@parndt it will be great if it's possible. If it's working we could only change refinerycms-i18n |
|
@simi What do you mean by reloader works ? |
|
https://github.com/rails/rails/blob/master/actionpack/lib/action_dispatch/middleware/reloader.rb Start dummy app, change route and try to reload page in dev. |
|
@simi it works. |
|
@bricesanchez do you still like this solution? |
|
@parndt i will check this soon but i always need this feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello all !
In addition to my PR refinery/refinerycms-i18n#51
I suggest this solution to add localized routes on refinerycms engine.
It will be great if the ActionDispatch::Routing::Mapper::localizable method will be directly added in refinerycms core to avoid duplicate code.
No need to fork route_translator with this solution :)
@parndt @simi