Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

look for resolution_shape='normal|uniform' in data file header #130

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pkienzle
Copy link
Member

@pkienzle pkienzle commented Jul 8, 2021

No description provided.

@bmaranville
Copy link
Member

@pkienzle - did you check that this does grab the resolution from a file when it is specified therein? If so, I have no objections to this and will merge immediately.

@pkienzle
Copy link
Member Author

pkienzle commented Nov 3, 2021

I haven't tested. reductus/reductus#130 implements the resolution_shape header key but it isn't merged yet.

Is that what we want to call it? Will we have the same shape for each data point? Do we want to jump immediately to a more general ORSO scheme?

@bmaranville
Copy link
Member

It seems like there are still some unanswered questions around this. For one, I wonder if we need to be clear that the 'normal' resolution function is truncated (and that the truncation is 3-sigma?). My vote is to defer merging until after the upcoming release.

@pkienzle
Copy link
Member Author

pkienzle commented Nov 3, 2021

There's an easy workaround so I have no problem with a delay. May want to ask some actual users though.

@glass-ships
Copy link
Member

Been a few years - should we revisit this?

@bmaranville
Copy link
Member

Yes, it needs to be manually recreated since load4 has changed some and we also want to support reading this metadata from orso files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants