Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup deprecated picom options #11

Merged
merged 1 commit into from
Dec 26, 2022
Merged

Conversation

mfisher87
Copy link
Member

@mfisher87 mfisher87 commented Dec 23, 2022

Cleanup deprecated picom options found in any looks.

With Regolith 2.2 I've been getting these in my logs using the nord look:

[ 12/23/2022 08:17:56.919 parse_config_libconfig WARN ] The refresh-rate option has been deprecated. Please remove it from your configuration file. If you encounter any problems without this feature, please feel free to open a bug report
[ 12/23/2022 08:17:56.919 parse_config_libconfig WARN ] The sw-opti option has been deprecated. Please remove it from your configuration file. If you encounter any problems without this feature, please feel free to open a bug report

My picom version is showing as:

$ picom --version
vgit-d4e24

Same change as regolith-linux/regolith-compositor-picom-glx#6

@kgilmer
Copy link
Member

kgilmer commented Dec 24, 2022

Looks good to me and thanks for the contribution @mfisher87 . Before merging, can you briefly describe how you tested this change?

@mfisher87
Copy link
Member Author

mfisher87 commented Dec 24, 2022

I didn't know how to do much other than this very simple smoke test: I killed picom with pkill -f picom and then reinitialized it with the config file in my local copy of the repo picom --config /path/to/picom.conf. Prior to the change, the deprecation warnings reproduced. After the change, the deprecation warnings were not printed. I have been using the altered config for a day now and have noticed no "smoke" :)

Copy link
Member

@kgilmer kgilmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgilmer kgilmer merged commit 4d560b2 into main Dec 26, 2022
@kgilmer kgilmer deleted the remove-deprecated-picom-opts branch December 26, 2022 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants