Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ayu, Ayu-Mirage & Ayu-Dark #5

Merged
merged 1 commit into from
Jun 26, 2022
Merged

Conversation

jjsearle
Copy link
Member

Colours are a bit different from 1.6 from looking at the old files but the new colours have been grabbed from here

https://raw.githubusercontent.com/ayu-theme/ayu-colors/master/colors.svg

Ayu

ayu

Ayu Mirage

ayu-mirage

Ayu Dark

ayu-dark

Copy link
Member

@kgilmer kgilmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look fantastic @jjsearle ! I'm happy to merge this as is.

Regarding style, most of nerdfonts are packaged for Regolith (notable exception is the Noto font, it's too big). We could give each look a more distinctive look with different fonts. Or, if you think SourceCodePro is best I won't argue with you.

Feel free to merge or look into other fonts, your call 🌞

@jjsearle
Copy link
Member Author

I just selected SourceCodePro because I think I remember seeing it referenced in the 1.6 files but I may be mistaken. I agree it would probably be better to pick a new font to make the looks more distinctive. I will take a look at nerdfonts and pick out a different one.

@jjsearle
Copy link
Member Author

Hey Ken - I have switched these three over to the 'Hack' font, if you are happy with this and don't want me to make any further changes please proceed with the merge. Thanks.

Copy link
Member

@kgilmer kgilmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ilia CSS needs the correct font spec, otherwise LGTM

usr/share/regolith-look/ayu-dark/ilia.css Outdated Show resolved Hide resolved
usr/share/regolith-look/ayu-mirage/ilia.css Outdated Show resolved Hide resolved
usr/share/regolith-look/ayu/ilia.css Outdated Show resolved Hide resolved
@jjsearle
Copy link
Member Author

I have corrected the ilya.css to use the new font

Copy link
Member

@kgilmer kgilmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgilmer kgilmer merged commit dcee2eb into regolith-linux:main Jun 26, 2022
@jjsearle jjsearle deleted the ayu branch June 26, 2022 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants