Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add static lib migrator #3755

Open
wants to merge 35 commits into
base: main
Choose a base branch
from
Open

feat: add static lib migrator #3755

wants to merge 35 commits into from

Conversation

beckermr
Copy link
Contributor

Description:

This PR adds a migrator to migrate static libs.

Checklist:

  • Pydantic model updated or no update needed

Cross-refs, links to issues, etc:

closes #3747

Copy link

codecov bot commented Feb 24, 2025

Codecov Report

Attention: Patch coverage is 88.04348% with 44 lines in your changes missing coverage. Please review.

Project coverage is 77.68%. Comparing base (fc356b4) to head (eeb4a4c).

Files with missing lines Patch % Lines
conda_forge_tick/migrators/staticlib.py 87.60% 31 Missing ⚠️
conda_forge_tick/make_migrators.py 7.14% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3755      +/-   ##
==========================================
+ Coverage   77.31%   77.68%   +0.36%     
==========================================
  Files         134      136       +2     
  Lines       14845    15213     +368     
==========================================
+ Hits        11478    11818     +340     
- Misses       3367     3395      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@beckermr beckermr marked this pull request as ready for review February 26, 2025 14:10
@beckermr
Copy link
Contributor Author

OK friends, this PR is ready for review!

It is a monster PR and I am happy to take suggestions on how to break it up into smaller chunks.

If nobody gets to it, that's fine.

I will merge eventually once we want to test it out somewhere, possibly with cmake-no-system or llvmlite or micromamba.

@beckermr beckermr marked this pull request as draft February 26, 2025 16:04
@beckermr
Copy link
Contributor Author

This PR will need changes based on discussion here: conda-forge/llvmlite-feedstock#100 (comment)

@beckermr beckermr marked this pull request as ready for review February 26, 2025 21:56
@beckermr
Copy link
Contributor Author

ok @isuruf @jaimergp this one is ready to go. The API has now been refactored.

@beckermr
Copy link
Contributor Author

xref for doc PR on smithy: conda-forge/conda-smithy#2253

Copy link
Contributor Author

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need these for new test format.

@beckermr
Copy link
Contributor Author

pre-commit.ci autofix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

static linkage migrations
2 participants