adding some info about Nextstrain clades to homepage #13
Conversation
…tles of sections on homepage as well.
|
@zkamvar I'm hoping to get some others from CDC to weigh in with content-related comments. I'd welcome both content comments from you as well as any comments on the structural pieces of the PR, although obviously this is kind of a simple one. One way or another, I'm going to wait to merge until we hear something from one of the CDC colleagues tagged above. |
There was a problem hiding this comment.
I can only comment on the structural elements. This looks fine to me. I only have a couple of suggestions on that note:
- Start with level-2 headers, not level-3 (accessibility)
- place the questions in a separate "FAQ" page
- place the next strain clades and pango lineages info in a callout block
|
@dylanhmorris was the username I was trying to find before... |
|
@zkamvar I made two small changes including moving to level-2 headers as you suggested. I'm going to punt on the FAQ and callout block for now, although those are good ideas. |
There was a problem hiding this comment.
@nickreich This looks reasonable to me, the justification is at the high enough level without being critical of pangolineages and the potential issues that arise from them when things get reclassified/expanded
|
@zkamvar Sorry, I caught one last typo. 🙈 |
updating titles of sections on homepage as well.
I'd like to make sure this gets some eyeballs from @katiejohnson @afmagee42 or Dylan (whose GitHub username I can't find right now) to make sure I'm not saying anything wrong here, and that this description feels like the right level of detail.
Noting that I've added to the main page of the dashaboard for the variant hub a brief section on the Nextstrain clades, hoping that this speaks to some public health users who might be less familiar with them. Below is a screenshot of the local build of the site with updates:
closes #8