Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing topic into consume method #62

Merged
merged 2 commits into from
Oct 27, 2014
Merged

Allow passing topic into consume method #62

merged 2 commits into from
Oct 27, 2014

Conversation

jamescway
Copy link
Contributor

The consume method should be allowed to consume whatever topic it wants without reinitializing.

@rtyler
Copy link
Member

rtyler commented Oct 25, 2014

This commit breaks the existing internal API for the Hermann::Consumer's internal provider, the MRI-based code might need to be updated. I might take a whack at that later

@jamescway
Copy link
Contributor Author

Oh forgot about that, I'll keep that in mind with future changes.

On Sat, Oct 25, 2014 at 10:41 AM, R. Tyler Croy [email protected]
wrote:

This commit breaks the existing internal API for the Hermann::Consumer's
internal provider, the MRI-based code might need to be updated. I might
take a whack at that later


Reply to this email directly or view it on GitHub
#62 (comment).

@rtyler
Copy link
Member

rtyler commented Oct 25, 2014

@jamescway I'm thinking getting rid of the C code (see #56) anyways to make this easier to deal with in the future

@jamescway
Copy link
Contributor Author

FFI looks interesting, commenting there

Note: this doesn't actually do anything just yet
@rtyler
Copy link
Member

rtyler commented Oct 27, 2014

The travis build appears to be failing due to a Travis bug, not ours, merging and we'll see what happens!

rtyler pushed a commit that referenced this pull request Oct 27, 2014
Allow passing topic into consume method
@rtyler rtyler merged commit 1f52bad into master Oct 27, 2014
@rtyler rtyler deleted the consume_topic branch October 27, 2014 21:04
@rtyler rtyler added this to the 0.19 milestone Oct 27, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants