Merge pull request #33 from Geod24/inref

Replace 'in ref' with 'const ref'
rejectedsoftware · Jun 10, 2024 · 85409d7 · 85409d7
2 parents a93d32b + 6db3a9a
commit 85409d7
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 7 deletions.
diff --git a/source/userman/api.d b/source/userman/api.d
@@ -109,7 +109,7 @@ interface UserManUserAPI {
 
 	/// Deletes a user account.
 	void remove(User.ID _user);
-	//void update(in ref User user);
+	//void update(in User user);
 
 	/// Updates the e-mail address of a user account.
 	void setEmail(User.ID _user, string email);
@@ -351,7 +351,7 @@ private class UserManUserAPIImpl : UserManUserAPI {
 		m_ctrl.deleteUser(id);
 	}
 
-	//void update(in ref User user);
+	//void update(in User user);
 
 	void setEmail(User.ID id, string email)
 	{

diff --git a/source/userman/db/controller.d b/source/userman/db/controller.d
@@ -55,7 +55,7 @@ class UserManController {
 
 	abstract bool isEmailRegistered(string email);
 
-	void validateUser(in ref User usr)
+	void validateUser(const ref User usr)
 	{
 		enforce(usr.name.length >= 3, "User names must be at least 3 characters long.");
 		validateEmail(usr.email);
@@ -229,7 +229,7 @@ class UserManController {
 
 	abstract void deleteUser(User.ID user_id);
 
-	abstract void updateUser(in ref User user);
+	abstract void updateUser(const ref User user);
 	abstract void setEmail(User.ID user, string email);
 	abstract void setFullName(User.ID user, string full_name);
 	abstract void setPassword(User.ID user, string password);

diff --git a/source/userman/db/file.d b/source/userman/db/file.d
@@ -131,7 +131,7 @@ class FileUserManController : UserManController {
 		removeFile(userFile(user_id));
 	}
 
-	override void updateUser(in ref User user)
+	override void updateUser(const ref User user)
 	{
 
 		enforce(existsFile(userFile(user.id)), "Invalid user ID.");

diff --git a/source/userman/db/mongo.d b/source/userman/db/mongo.d
@@ -132,7 +132,7 @@ class MongoUserManController : UserManController {
 		m_users.remove(["_id": user_id.bsonObjectIDValue]);
 	}
 
-	override void updateUser(in ref User user)
+	override void updateUser(const ref User user)
 	{
 		validateUser(user);
 		enforce(m_settings.useUserNames || user.name == user.email, "User name must equal email address if user names are not used.");

diff --git a/source/userman/db/redis.d b/source/userman/db/redis.d
@@ -219,7 +219,7 @@ class RedisUserManController : UserManController {
 			removeGroupMember(gid, user_id);
 	}
 
-	override void updateUser(in ref User user)
+	override void updateUser(const ref User user)
 	{
 		enforce(m_users.isMember(user.id.longValue), "Invalid user ID.");
 		validateUser(user);