Skip to content

Commit

Permalink
Remove Gemfile.lock and remove bundler dependency
Browse files Browse the repository at this point in the history
  • Loading branch information
ronaldtse committed Dec 23, 2019
1 parent 2ccba4c commit 67d3a56
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 68 deletions.
67 changes: 0 additions & 67 deletions Gemfile.lock

This file was deleted.

1 change: 0 additions & 1 deletion relaton-bib.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ Gem::Specification.new do |spec|
spec.require_paths = ["lib"]
spec.required_ruby_version = Gem::Requirement.new(">= 2.4.0")

spec.add_development_dependency "bundler"
spec.add_development_dependency "debase"
spec.add_development_dependency "equivalent-xml", "~> 0.6"
spec.add_development_dependency "rake", "~> 10.0"
Expand Down

4 comments on commit 67d3a56

@andrew2net
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ronaldtse why have you removed the Gemgile.lock?

@ronaldtse
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We were getting too many issues with bundler versions, and Bundler itself discourages the usage of Gemfie.lock inside git repos. Previously we used Gemfile.lock to ensure the specs work under a certain version, but since the version dependencies are propagated via gemspec, it would be better to set dependencies only via gemspec to ensure things work on the user machine.

@andrew2net
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious about what kind of problem?

@ronaldtse
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Specs pass, but actual installation usage fails.

Please sign in to comment.