-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Remove Gemfile.lock and remove bundler dependency
- Loading branch information
Showing
2 changed files
with
0 additions
and
68 deletions.
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
67d3a56
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ronaldtse why have you removed the
Gemgile.lock
?67d3a56
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We were getting too many issues with bundler versions, and Bundler itself discourages the usage of Gemfie.lock inside git repos. Previously we used Gemfile.lock to ensure the specs work under a certain version, but since the version dependencies are propagated via gemspec, it would be better to set dependencies only via gemspec to ensure things work on the user machine.
67d3a56
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious about what kind of problem?
67d3a56
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Specs pass, but actual installation usage fails.