Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to use @import to import types #836

Merged
merged 2 commits into from
Jun 28, 2024
Merged

Refactor to use @import to import types #836

merged 2 commits into from
Jun 28, 2024

Conversation

remcohaszing
Copy link
Member

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

This replaces @typedef tags with @import where applicable. @import tags were introduced in TypeScript 5.5.

`@import` tags were introduced in TypeScript 5.5.
@remcohaszing remcohaszing added ☂️ area/types This affects typings 👶 semver/patch This is a backwards-compatible fix 🦋 type/enhancement This is great to have 🤞 phase/open Post is being triaged manually labels Jun 28, 2024
lib/index.js Outdated
@@ -2,15 +2,11 @@
/// <reference types="mdast-util-to-hast" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one too?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just removing it turned out to be fine.

@wooorm wooorm changed the title Use @import jsdoc comments to import types Refactor to use @import to import types Jun 28, 2024
@wooorm wooorm merged commit aa5933b into main Jun 28, 2024
4 checks passed
@wooorm wooorm deleted the type-imports branch June 28, 2024 10:08
@wooorm wooorm added the 💪 phase/solved Post is done label Jun 28, 2024

This comment has been minimized.

@github-actions github-actions bot removed the 🤞 phase/open Post is being triaged manually label Jun 28, 2024
@wooorm
Copy link
Member

wooorm commented Jun 28, 2024

thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
☂️ area/types This affects typings 💪 phase/solved Post is done 👶 semver/patch This is a backwards-compatible fix 🦋 type/enhancement This is great to have
Development

Successfully merging this pull request may close these issues.

2 participants