docs(guides/gotchas): remove typeof window gotcha
#10225
Conversation
Deno since version 2 has erased the `window` global. https://deno.com/blog/v2.0-release-candidate#changes-to-global-variables
|
Hi @avindra, Welcome, and thank you for contributing to Remix! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected]. Thanks! - The Remix team |
|
avindra
changed the title
|
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
MichaelDeBoey
changed the title
typeof window gotcha
MichaelDeBoey
requested review from
markdalgleish,
brophdawg11 and
brookslybrand
| Because the same JavaScript code can run in the browser as well as the server, sometimes you need to have a part of your code that only runs in one context or the other: | ||
|
|
||
| ```ts bad | ||
| if (typeof window === "undefined") { | ||
| // running in a server environment | ||
| } else { | ||
| // running in a browser environment | ||
| } | ||
| ``` |
There was a problem hiding this comment.
This part still seems relevant, it seems like only the deno specific part should be removed
Deno since version 2 has erased the
windowglobal.https://deno.com/blog/v2.0-release-candidate#changes-to-global-variables