Refactor: Extract say to its own file #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I really like the idea, but I would have expected it to be its own package and export just few functions and not all. What do you think about this? |
hollesse
requested changes
Sep 20, 2022
|
You're just teaching me some go, and I love it! |
gregorriegler
force-pushed
the
refactor-extract-say
branch
from
bfdbdd7
to
6d2b68b
Compare
|
I'm stuck. The tests finish with an exit code and I don't know why. |
|
Ok, I understand now. Trying to find a solution |
|
solved |
gregorriegler
force-pushed
the
refactor-extract-say
branch
from
b2074af
to
c61db28
Compare
hollesse
reviewed
Sep 20, 2022
hollesse
reviewed
Sep 20, 2022
gregorriegler
force-pushed
the
refactor-extract-say
branch
from
9f63182
to
8b344a2
Compare
|
"Error: ./mob.go:1150:3: undefined: sayFix" this is not the version I would have liked it to use. |
gregorriegler
force-pushed
the
refactor-extract-say
branch
from
c572e98
to
c7c7a94
Compare
|
ok, we got this. |
hollesse
approved these changes
Sep 21, 2022
| @@ -664,55 +654,55 @@ func printDeprecatedDoneSquashMessage(value string) { | |||
|
|
|||
| if unquotedValue == "true" || unquotedValue == "false" { | |||
| newValue := doneSquash(unquotedValue) | |||
| say("MOB_DONE_SQUASH is set to the deprecated value " + value + ". Use the value " + newValue + " instead.") | |||
| say.Say("MOB_DONE_SQUASH is set to the deprecated value " + value + ". Use the value " + newValue + " instead.") | |||
| } | ||
| } | ||
|
|
||
| func removed(key string, message string) { | ||
| if _, set := os.LookupEnv(key); set { | ||
| say("Configuration option '" + key + "' is no longer used.") | ||
| say(message) | ||
| say.Say("Configuration option '" + key + "' is no longer used.") |
| say("Configuration option '" + key + "' is no longer used.") | ||
| say(message) | ||
| say.Say("Configuration option '" + key + "' is no longer used.") | ||
| say.Say(message) |
| } | ||
| } | ||
|
|
||
| func deprecated(key string, message string) { | ||
| if _, set := os.LookupEnv(key); set { | ||
| say("Configuration option '" + key + "' is deprecated.") | ||
| say(message) | ||
| say.Say("Configuration option '" + key + "' is deprecated.") |
| say("Configuration option '" + key + "' is deprecated.") | ||
| say(message) | ||
| say.Say("Configuration option '" + key + "' is deprecated.") | ||
| say.Say(message) |
| } | ||
| } | ||
|
|
||
| func experimental(key string) { | ||
| if _, set := os.LookupEnv(key); set { | ||
| say("Configuration option '" + key + "' is experimental. Be prepared that this option will be removed!") | ||
| say.Say("Configuration option '" + key + "' is experimental. Be prepared that this option will be removed!") |
| @@ -877,10 +867,10 @@ func (branch Branch) isOrphanWipBranch(configuration Configuration) bool { | |||
| } | |||
|
|
|||
| func branch(configuration Configuration) { | |||
| say(silentgit("branch", "--list", "--remote", newBranch("*").addWipPrefix(configuration).remote(configuration).Name)) | |||
| say.Say(silentgit("branch", "--list", "--remote", newBranch("*").addWipPrefix(configuration).remote(configuration).Name)) | |||
There was a problem hiding this comment.
does that make sense? why don't we use git instead of say.Say(silentgit(...))
|
|
||
| // DEPRECATED | ||
| say(silentgit("branch", "--list", "--remote", newBranch("mob-session").remote(configuration).Name)) | ||
| say.Say(silentgit("branch", "--list", "--remote", newBranch("mob-session").remote(configuration).Name)) |
|
I agree with all the points you made, however it is not a part of the change I'm trying to make in this pr. I just want to move say to its own package. We should improve how say is used, but that's another step. Let's make small steps and integrate often. |
|
I agree. That's why I approved the PR but leaved the comments. |
|
Ah, I didn't get that. So I'll merge it then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A first step tackling #296