Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated endpoints and other clean up #10

Merged
merged 3 commits into from
Mar 26, 2024

Conversation

zamith
Copy link

@zamith zamith commented Mar 20, 2024

Why:

  • There's some endpoints that have been hard deprecated by Stripe and we can now remove.
  • The way we run application from the mix file is also deprecated. Meaning we don't need to pass anything to applications anymore.

This change addresses the need by:

  • Removing the unused endpoint modules and tests
  • Removing the applications option in mix.exs
  • Fixes some more Elixir warnings
  • Bump hackney's version

Why:

* There's some endpoints that have been hard deprecated by Stripe and we
  can now remove.
* The way we run application from the mix file is also deprecated.
  Meaning we don't need to pass anything to `applications` anymore.

This change addresses the need by:

* Removing the unused endpoint modules and tests
* Removing the `applications` option in `mix.exs`
* Fixes some more Elixir warnings
* Bump hackney's version
Copy link
Collaborator

@amalbuquerque amalbuquerque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to approve and merge after we confirm the :dev vs :prod change is what we really want to have 🙏

Thank you for this!

lib/stripe/converter.ex Outdated Show resolved Hide resolved
@amalbuquerque amalbuquerque merged commit a68a1a9 into remoteoss:remote Mar 26, 2024
1 of 10 checks passed
@zamith zamith deleted the clean-up branch March 26, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants