You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
BREAKING: Moved constant InvoiceGenerator::CAN_GENERATE_DAYS_LIMIT to InvoicesRepository::PAYMENT_INVOICEABLE_PERIOD_DAYS. remp/crm#1267
BREAKING: Command SendInvoiceCommand fails if invoice wasn't generated. There is no point of sending empty email from "send invoice" command. remp/crm#1267
Moved Invoices:invoiceDetails page implementation to InvoiceDetailsWidget. With this change we can reuse invoice details form in multiple places. InvoiceDetailsWidget attaches to new invoices.frontend.invoice_details widget placeholder created in Invoices:invoiceDetails page, so page stays the same. remp/crm#1818
Changed checking if invoice can be generated or is within invoiceable period from custom conditions to unified InvoicesRepository->isPaymentInvoiceable() and InvoicesRepository->paymentInInvoiceablePeriod() methods.
Affected are InvoicesPresenter->actionDownloadInvoice(), InvoicesAdminPresenter->actionDownloadInvoice() and InvoiceButton component.
No breaking change in functionality. Unified condition checking if payment is in invoiceable period is more precise (see commit message for detailed explanation). remp/crm#1267
Removed redundant check if invoicing was disabled in InvoiceGenerator->renderInvoiceMailAttachment(). Conditions if payment is invoiceable are checked later in generate(). Invoice is now attached to email also if it was generated but user disabled invoicing (after generation and) before email was sent. remp/crm#1267
Added handling for exceptions from InvoiceGenerator->renderInvoiceMailAttachment() where it was missing.
