Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade to deno 1.42.3 #931

Merged
merged 3 commits into from
Apr 13, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ on:
env:
# be sure to also update these in other workflows
DENO_DIR: deno_dir
DENO_VERSION: "1.40.3"
DENO_VERSION: "1.42.3"

jobs:
build:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ on:
env:
# be sure to also update these in other workflows
DENO_DIR: deno_dir
DENO_VERSION: "1.40.3"
DENO_VERSION: "1.42.3"

jobs:
lint:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/prepare-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ on:
env:
# be sure to also update these in other workflows
DENO_DIR: deno_dir
DENO_VERSION: "1.40.3"
DENO_VERSION: "1.42.3"

jobs:
prepare-release:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release-jsr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ on:
env:
# be sure to also update these in other workflows
DENO_DIR: deno_dir
DENO_VERSION: "1.40.3"
DENO_VERSION: "1.42.3"

permissions:
contents: read
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release-npm.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ on:
env:
# be sure to also update these in other workflows
DENO_DIR: deno_dir
DENO_VERSION: "1.40.3"
DENO_VERSION: "1.42.3"

permissions: {}
jobs:
Expand Down
2 changes: 1 addition & 1 deletion src/util/binarySerialization.js
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ export function binaryToUuid(buffer, offset = 0) {
if (i == 3 || i == 5 || i == 7 || i == 9) str += "-";
}
if (allZeros) return null;
return str;
return /** @type {import("./util.js").UuidString} */ (str);
}

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ export class StudioConnectionsManager {
* But pages created by the build view should always be allowed.
* Therefore, we create tokens for every page created by the build view.
* Inspectors can provide these tokens when connecting, and we'll always allow the connection when the token is valid.
* @type {Set<string>}
* @type {Set<import("../../../../src/mod.js").UuidString>}
*/
#connectionTokens = new Set();

Expand Down Expand Up @@ -397,7 +397,7 @@ export class StudioConnectionsManager {
* regardless of its origin, the connection type, or whether internal connections are enabled.
*/
createConnectionToken() {
const token = crypto.randomUUID();
const token = /** @type {import("../../../../src/mod.js").UuidString} */ (crypto.randomUUID());
this.#connectionTokens.add(token);
return token;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ async function basicTest({
let randomUuid = 0;
const mockUuid = stub(crypto, "randomUUID", () => {
randomUuid++;
return "random_uuid_" + randomUuid;
return /** @type {`${string}-${string}-${string}-${string}-${string}`} */ ("random_uuid_" + randomUuid);
});
const oldLocation = window.location;
try {
Expand Down
6 changes: 5 additions & 1 deletion test/unit/studio/src/ui/popoverMenus/PopoverManager.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ testTypes({

Deno.test({
name: "context menu creation",
fn() {
async fn() {
const { manager, uninstall } = basicManager();
try {
assertEquals(manager.curtainEl.parentElement, null);
Expand All @@ -137,6 +137,10 @@ Deno.test({

assertEquals(manager.removePopover(contextMenu), true);
assertEquals(manager.removePopover(contextMenu), false);

// Some extra code is run in the next event loop when creating a popover.
// We need to wait for this code to run, otherwise the test sanitizer will complain.
await waitForMicrotasks();
} finally {
uninstall();
}
Expand Down
Loading