auth-server: add output net of fees #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sehyunc
force-pushed
the
sehyun/fee-costs
branch
4 times, most recently
from
f46c721 to
a15636c
Compare
sehyunc
force-pushed
the
sehyun/fee-costs
branch
from
a15636c to
765021e
Compare
joeykraut
approved these changes
Jan 21, 2025
Comment on lines
59
to
63
| let diff_ratio = (our_output_value_net_of_fee - source_output_value_net_of_fee) | ||
| / source_output_value_net_of_fee; | ||
| let bps_diff = diff_ratio * DECIMAL_TO_BPS; | ||
|
|
||
| bps_diff as i32 |
There was a problem hiding this comment.
we should probably do this as an f64 calculation, rather than using an integral type. precision matters for these metrics and rounding down to the nearest basis point is not a precision loss I feel good about.
Same with the gas diff metric
|
|
||
| /// Internal helper that calculates the net output value with configurable | ||
| /// deductions. | ||
| fn calculate_net_output( |
There was a problem hiding this comment.
This helper doesn't seem very valuable, in general I'm against helpers that are just a bunch of boolean switches -- they become dumping grounds for one-off behaviors and they don't capture anything general.
Maybe what we can do is refactor the common behavior into a helper get_receive_amount_mint and then each of the callers of this method can call the respective deduction helpers or just inline the logic
sehyunc
force-pushed
the
sehyun/fee-costs
branch
from
765021e to
bf3e05f
Compare
sehyunc
force-pushed
the
sehyun/fee-costs
branch
from
bf3e05f to
ef6fe5b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR takes into account fees when recording quote comparison metrics. We do so by calculating the fee take amount and storing it in the
QuoteResponsestruct.Testing