auth-server: record metrics for output net of gas and fees #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeykraut
approved these changes
Jan 21, 2025
Comment on lines
74
to
79
| let diff_ratio = (our_output_value_net_of_gas - source_output_value_net_of_gas) | ||
| / source_output_value_net_of_gas; | ||
| let bps_diff = diff_ratio * DECIMAL_TO_BPS; | ||
|
|
||
| bps_diff as i32 |
There was a problem hiding this comment.
same as the last PR, this should probably be an f64 computation. Also, since it shows up so much, might be worth refactoring into a helper
sehyunc
force-pushed
the
sehyun/fee-costs
branch
2 times, most recently
from
bf3e05f to
ef6fe5b
Compare
sehyunc
force-pushed
the
sehyun/net-costs
branch
3 times, most recently
from
62c3d4a to
dc2e180
Compare
sehyunc
force-pushed
the
sehyun/net-costs
branch
from
dc2e180 to
2b257a2
Compare
sehyunc
force-pushed
the
sehyun/net-costs
branch
from
2b257a2 to
1f5392d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR records metrics net of both gas costs and fees.
Testing