Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auth-server: rate-limiter: Rate limit quote endpoint #95

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

joeykraut
Copy link
Member

@joeykraut joeykraut commented Jan 21, 2025

Purpose

This PR adds rate limits to the quote endpoint for external matches, starting at 100 requests/min.

I also took care of some clippy lints around missing docs.

Testing

  • Testing in testnet

@joeykraut joeykraut force-pushed the joey/quote-rate-limits branch from fab6c57 to 988e005 Compare January 21, 2025 15:19
@joeykraut joeykraut requested a review from sehyunc January 21, 2025 15:21
@joeykraut joeykraut force-pushed the joey/quote-rate-limits branch from 988e005 to fec4010 Compare January 21, 2025 15:26
Copy link
Contributor

@sehyunc sehyunc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. thank you for adding docs comments, will be sure to do that in the future

@joeykraut joeykraut merged commit 2f05f59 into main Jan 21, 2025
4 checks passed
@joeykraut joeykraut deleted the joey/quote-rate-limits branch January 21, 2025 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants