Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic CI and PR policy to ensure integraty of commits #7

Open
ddio opened this issue Nov 14, 2019 · 1 comment
Open

Basic CI and PR policy to ensure integraty of commits #7

ddio opened this issue Nov 14, 2019 · 1 comment

Comments

@ddio
Copy link
Member

ddio commented Nov 14, 2019

As a project member, I want to make sure the commits I push to Github won't affect existing feature, so to reduce effort for manual code review and communication cost.

This issue is also related to #2 , as we can run unit test also in CI when it's ready.

Acceptance Criteria

  1. A CI environment that will run all spiders with simple command, say, minuteago=10 target_cities=台北市 and ensure they get meaningful results.
  2. The CI should be triggered on every PR, and everyone must merge code by PR.
@ddio
Copy link
Member Author

ddio commented Nov 25, 2019

Looks like Github built-in CI/CD supports everything we need. Although there seem to be some drawback, they have either been resolved, like live log, or is not a required feature for this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant