Add sentry to scrapy #6
Conversation
| } | ||
| # Send exceptions to Sentry | ||
| # replace SENTRY_DSN by you own DSN | ||
| SENTRY_DSN = "https://[email protected]/1817994" |
There was a problem hiding this comment.
Please dont't commit any environment setting into git. A typical solution would be read this from environment variable, or from an optional config file. XD
In addition, it would be better if we can make Sentry to be optional, so even people without knowledge of Sentry, or doesn't want to send info to Sentry, can use this tool.
There was a problem hiding this comment.
OK I will fix this issue. Thanks for your review
There was a problem hiding this comment.
Forgot to mention, could you also help to add related description into README.md? Than other people will know now this tool support Sentry! Thanks~
|
@jenhaoyang , BTW, I can't find update about Looks like it's time to add some simple CI script. I've created one ticket to track this requirement. XD |
Add sentry to scrapy
for issue #3 Enable Sentry in crawler