Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrects regression in setup scripts that fetch the SDK version #353

Merged
merged 4 commits into from
Oct 14, 2024

Conversation

crdant
Copy link
Member

@crdant crdant commented Oct 14, 2024

TL;DR

Stops track setup scripts from stripping the 1 from the SDK version

Details

Fixes a defect in track setup scripts for the "Avoiding Installation
Pitfalls", "Closing the Support Installation Gap", and "Protecting Your
Assets" labs that caused the 1 to be stripped from the SDK version
when the track was created. This defect was introduced when I updated the
function that fetches the SDK version to use the chart registry instead of
GitHub.

The old code resulted in a version string that included a v at the
beginning from the GitHub tag, which was stripped on use. The version tags in
the registry do not have a v prefix, and I had lazily removed the v prefix
by dropping the first character of the version string. This resulted in the
1 being stripped once the function changes. This change removes the
expressions that dropped the first character of the version string.

It also assures that track metadata updates Instruqt inserted into several
files in the affected labs is under source control.

@crdant crdant added type::bug Something isn't working bug::regression labels Oct 14, 2024
@crdant crdant merged commit ca2f4a4 into main Oct 14, 2024
2 of 7 checks passed
@crdant crdant deleted the fix/crdant/corrects-sdk-version-regression branch October 14, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug::regression type::bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant